szaszm commented on code in PR #1460:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1460#discussion_r1035972201
##########
examples/kubernetes/daemon-set-log-collection/daemon-set-log-collection.yml:
##########
@@ -30,6 +30,7 @@ data:
nifi.provenance.repository.max.storage.time=1 MIN
nifi.provenance.repository.max.storage.size=1 MB
nifi.flowfile.repository.directory.default=${MINIFI_HOME}/flowfile_repository
+
nifi.flowfile.checkpoint.directory.default=${MINIFI_HOME}/flowfile_checkpoint
Review Comment:
I think the property is not relevant here, so I would leave it out from the
example. I would ideally also remove all other properties that are using their
default values, to keep the example minimal, but that doesn't need to happen in
this PR.
##########
examples/kubernetes/sidecar-log-collection/sidecar-log-collection.yml:
##########
@@ -32,6 +32,7 @@ data:
nifi.provenance.repository.max.storage.time=1 MIN
nifi.provenance.repository.max.storage.size=1 MB
nifi.flowfile.repository.directory.default=${MINIFI_HOME}/flowfile_repository
+
nifi.flowfile.checkpoint.directory.default=${MINIFI_HOME}/flowfile_checkpoint
Review Comment:
I think the property is not relevant here, so I would leave it out from the
example. I would ideally also remove all other properties that are using their
default values, to keep the example minimal, but that doesn't need to happen in
this PR.
##########
CONFIGURE.md:
##########
@@ -119,23 +119,23 @@ for TCP and secure HTTPS communications.
name: tominifi
max concurrent tasks: 2
Properties:
- SSL Context Service: SSLServiceName
Review Comment:
The old indentation was the correct one for SSL Context Service, since it's
a property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
