adam-markovics commented on code in PR #1432:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1042144555


##########
PROCESSORS.md:
##########
@@ -337,28 +337,34 @@ This Processor gets the contents of a FlowFile from a 
MQTT broker for a specifie
 
 In the list below, the names of required properties appear in bold. Any other 
properties (not in bold) are considered optional. The table also indicates any 
default values, and whether a property supports the NiFi Expression Language.
 
-| Name                  | Default Value | Allowable Values | Description       
                                                                                
                          |
-|-----------------------|---------------|------------------|-----------------------------------------------------------------------------------------------------------------------------|
-| **Broker URI**        |               |                  | The URI to use to 
connect to the MQTT broker                                                      
                          |
-| **Topic**             |               |                  | The topic to 
subscribe to                                                                    
                               |
-| Client ID             |               |                  | MQTT client ID to 
use                                                                             
                          |
-| Quality of Service    | 0             |                  | The Quality of 
Service (QoS) to receive the message with. Accepts three values '0', '1' and 
'2'                             |
-| Connection Timeout    | 30 sec        |                  | Maximum time 
interval the client will wait for the network connection to the MQTT broker     
                               |
-| Keep Alive Interval   | 60 sec        |                  | Defines the 
maximum time interval between messages being sent to the broker                 
                                |
-| Max Flow Segment Size |               |                  | Maximum flow 
content payload segment size for the MQTT record                                
                               |
-| Last Will Topic       |               |                  | The topic to send 
the client's Last Will to. If the Last Will topic is not set then a Last Will 
will not be sent            |
-| Last Will Message     |               |                  | The message to 
send as the client's Last Will. If the Last Will Message is empty, Last Will 
will be deleted from the broker |
-| Last Will QoS         | 0             |                  | The Quality of 
Service (QoS) to send the last will with. Accepts three values '0', '1' and '2' 
                             |
-| Last Will Retain      | false         |                  | Whether to retain 
the client's Last Will                                                          
                          |
-| Security Protocol     |               |                  | Protocol used to 
communicate with brokers                                                        
                           |
-| Security CA           |               |                  | File or directory 
path to CA certificate(s) for verifying the broker's key                        
                          |
-| Security Cert         |               |                  | Path to client's 
public key (PEM) used for authentication                                        
                           |
-| Security Private Key  |               |                  | Path to client's 
private key (PEM) used for authentication                                       
                           |
-| Security Pass Phrase  |               |                  | Private key 
passphrase                                                                      
                                |
-| Username              |               |                  | Username to use 
when connecting to the broker                                                   
                            |
-| Password              |               |                  | Password to use 
when connecting to the broker                                                   
                            |
-| Clean Session         | true          |                  | Whether to start 
afresh rather than remembering previous subscriptions                           
                           |
-| Queue Max Message     | 1000          |                  | Maximum number of 
messages allowed on the received MQTT queue                                     
                          |
+| Name                        | Default Value | Allowable Values            | 
Description                                                                     
                                                                            |
+|-----------------------------|---------------|-----------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| **Broker URI**              |               |                             | 
The URI to use to connect to the MQTT broker                                    
                                                                            |
+| Client ID                   |               |                             | 
MQTT client ID to use. WARNING: Must not be empty when using MQTT 3.1.0!        
                                                                            |
+| MQTT Version                | 3.x AUTO      | 3.x AUTO, 3.1.0, 3.1.1, 5.0 | 
The MQTT specification version when connecting to the broker.                   
                                                                            |
+| **Topic**                   |               |                             | 
The topic to subscribe to.                                                      
                                                                            |
+| Clean Session               | true          |                             | 
Whether to start afresh rather than remembering previous subscriptions. Also 
make broker remember subscriptions after disconnected. WARNING: MQTT 3.x only. |
+| Clean Start                 | true          |                             | 
Whether to start afresh rather than remembering previous subscriptions. 
WARNING: MQTT 5.x only.                                                         
    |

Review Comment:
   What used to be Clean Session in MQTT 3 is fundamentally altered in MQTT 5. 
Now MQTT 3's Clean Session = false behavior can be achieved with the 
combination of two properties: Clean Start = false and Session Expiry Interval 
> 0. Further explanation here: 
https://www.hivemq.com/blog/mqtt5-essentials-part2-foundational-changes-in-the-protocol/
   I think this change is big enough (one of the largest from 3 to 5) to 
separate the two properties.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to