[
https://issues.apache.org/jira/browse/NIFI-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15674339#comment-15674339
]
ASF GitHub Bot commented on NIFI-3039:
--------------------------------------
GitHub user jskora opened a pull request:
https://github.com/apache/nifi/pull/1240
NIFI-3039 Provenance Repository - Fix PurgeOldEvent and Rollover Size
Limits (1.x)
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x ] Is your initial contribution a single, squashed commit?
### For code changes:
- [x ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
NIFI-3039 Provenance Repository - Fix PurgeOldEvent and Rollover Size Limits
* Added low water mark for purgeOldEvents() to prevent thrashing on event
cleanup.
* Adjusted rollover high water mark to match purgeOldEvents() to prevent
overrunning "nifi.provenance.repository.max.storage.size".
* Moved high/low water marks to constants.
* Adjusted looping logic in mergeJournals() to use ".firstKey()" instead of
".entrySet().iterator().next()" to avoid unnecessary object creation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jskora/nifi NIFI-3039-1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1240.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1240
----
commit 205f9805c39d4a0027699c9426853923d83f724d
Author: Joe Skora <[email protected]>
Date: 2016-11-17T15:30:52Z
NIFI-3039 Provenance Repository - Fix PurgeOldEvent and Rollover Size Limits
* Added low water mark for purgeOldEvents() to prevent thrashing on event
cleanup.
* Adjusted rollover high water mark to match purgeOldEvents() to prevent
overrunning "nifi.provenance.repository.max.storage.size".
* Moved high/low water marks to constants.
* Adjusted looping logic in mergeJournals() to use ".firstKey()" instead of
".entrySet().iterator().next()" to avoid unnecessary object creation.
----
> Provenance Repository - Fix PurgeOldEvent and Rollover Size Limits
> ------------------------------------------------------------------
>
> Key: NIFI-3039
> URL: https://issues.apache.org/jira/browse/NIFI-3039
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.0.0, 1.1.0, 0.8.0, 0.7.1
> Reporter: Joe Skora
> Assignee: Joe Skora
>
> Current {purgeOldEvents} logic triggers cleanup when 90% of space is used,
> but it only removes one file if usage is under 100%, causing thrashing around
> 100% usage. In testing, cleanup up to 70% after hitting 90% makes the system
> run more smoothly.
> Also, {rollover} will not trigger cleanup unless 110% of the allowed space is
> in use, changing this to 100% also make a difference in testing.
> Before these changes, a test system that generates huge amounts of provenance
> would become unstable and stop processing provenance until restarted. With
> these changes, the system consistently recovers even under heavy load.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
