martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044570304
##########
extensions/standard-processors/tests/unit/GenerateFlowFileTests.cpp:
##########
@@ -57,9 +57,9 @@ TEST_CASE("GenerateFlowFileTest", "[generateflowfiletest]") {
std::vector<std::string> file_contents;
- auto lambda = [&file_contents](const std::string& path, const std::string&
filename) -> bool {
- std::ifstream is(path + utils::file::get_separator() + filename,
std::ifstream::binary);
- file_contents.push_back(std::string((std::istreambuf_iterator<char>(is)),
std::istreambuf_iterator<char>()));
+ auto lambda = [&file_contents](const std::filesystem::path& path, const
std::filesystem::path& filename) -> bool {
+ std::ifstream is(path / filename, std::ifstream::binary);
+ file_contents.emplace_back((std::istreambuf_iterator<char>(is)),
std::istreambuf_iterator<char>());
Review Comment:
fixed them in
https://github.com/apache/nifi-minifi-cpp/pull/1424/commits/6c775d116236c92105c7be38bb284f309c27887c#diff-5aa458ae662cf99a08e2c71b3db9668cff5b9343a864e20a16b19c37388e7bf6R62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
