exceptionfactory commented on code in PR #6775: URL: https://github.com/apache/nifi/pull/6775#discussion_r1046647523
########## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/wali/EncryptedSequentialAccessWriteAheadLogTest.groovy: ########## @@ -17,30 +17,26 @@ package org.apache.nifi.wali - -import org.apache.commons.lang3.SystemUtils import org.apache.nifi.controller.queue.FlowFileQueue import org.apache.nifi.controller.repository.* import org.apache.nifi.controller.repository.claim.ResourceClaimManager import org.apache.nifi.controller.repository.claim.StandardResourceClaimManager import org.apache.nifi.repository.schema.NoOpFieldCache import org.apache.nifi.security.kms.StaticKeyProvider import org.apache.nifi.util.NiFiProperties -import org.bouncycastle.jce.provider.BouncyCastleProvider -import org.junit.* -import org.junit.rules.TestName -import org.junit.runner.RunWith -import org.junit.runners.JUnit4 +import org.junit.jupiter.api.* Review Comment: This should be changed to use explicit imports. ########## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/wali/EncryptedSequentialAccessWriteAheadLogTest.groovy: ########## @@ -17,30 +17,26 @@ package org.apache.nifi.wali - -import org.apache.commons.lang3.SystemUtils import org.apache.nifi.controller.queue.FlowFileQueue import org.apache.nifi.controller.repository.* import org.apache.nifi.controller.repository.claim.ResourceClaimManager import org.apache.nifi.controller.repository.claim.StandardResourceClaimManager import org.apache.nifi.repository.schema.NoOpFieldCache import org.apache.nifi.security.kms.StaticKeyProvider import org.apache.nifi.util.NiFiProperties -import org.bouncycastle.jce.provider.BouncyCastleProvider -import org.junit.* -import org.junit.rules.TestName -import org.junit.runner.RunWith -import org.junit.runners.JUnit4 +import org.junit.jupiter.api.* +import org.junit.jupiter.api.condition.DisabledOnOs +import org.junit.jupiter.api.condition.OS import org.slf4j.Logger import org.slf4j.LoggerFactory import org.wali.SerDe import org.wali.SerDeFactory import org.wali.SingletonSerDeFactory -import java.security.Security +import static org.junit.jupiter.api.Assertions.* Review Comment: This should be changed to explicit imports ########## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/TestStandardFlowFileQueue.java: ########## @@ -37,10 +37,10 @@ import org.apache.nifi.provenance.ProvenanceEventRepository; import org.apache.nifi.provenance.ProvenanceEventType; import org.apache.nifi.provenance.StandardProvenanceEventRecord; -import org.junit.Assert; -import org.junit.Before; -import org.junit.BeforeClass; -import org.junit.Test; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.BeforeAll; Review Comment: This import needs to be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
