arun-prakash-fokus commented on PR #6651:
URL: https://github.com/apache/nifi/pull/6651#issuecomment-1350965158

   Furthermore, I would like to suggest the following naming convention for the 
`environment` variables keeping in line with the naming conventions of the 
`TLS` and `LDAP` variables.
   
   `nifi-docker/dockerhub/sh/update_oidc_properties.sh`
   ```yml
   ...
   prop_replace 'nifi.security.user.oidc.discovery.url'                    
"${OIDC_DISCOVERY_URL:-}"
   prop_replace 'nifi.security.user.oidc.connect.timeout'                  
"${OIDC_CONNECT_TIMEOUT:-'5 secs'}"
   prop_replace 'nifi.security.user.oidc.read.timeout'                     
"${OIDC_READ_TIMEOUT:-'5 secs'}"
   prop_replace 'nifi.security.user.oidc.client.id'                        
"${OIDC_CLIENT_ID:-}"
   prop_replace 'nifi.security.user.oidc.client.secret'                    
"${OIDC_CLIENT_SECRET:-}"
   prop_replace 'nifi.security.user.oidc.preferred.jwsalgorithm'           
"${OIDC_PREFERRED_JWSALGORITHM:-}"
   prop_replace 'nifi.security.user.oidc.additional.scopes'                
"${OIDC_ADDITIONAL_SCOPES:-}"
   prop_replace 'nifi.security.user.oidc.claim.identifying.user'           
"${OIDC_CLAIM_IDENTIFYING_USER:-}"
   prop_replace 'nifi.security.user.oidc.fallback.claims.identifying.user' 
"${OIDC_FALLBACK_CLAIMS_IDENTIFYING_USER:-}"
   prop_replace 'nifi.security.user.oidc.truststore.strategy'              
"${OIDC_TRUSTSTORE_STRATEGY:-'JDK'}"
   ```
   
   
   `nifi-docker/dockerhub/sh/update_oidc_properties.sh` and 
`nifi-registry/nifi-registry-docker-maven/dockermaven/sh/update_oidc_properties.sh`
   
   ```yml
   ...
   prop_replace 'nifi.registry.security.user.oidc.discovery.url'           
"${OIDC_DISCOVERY_URL:-}"
   prop_replace 'nifi.registry.security.user.oidc.connect.timeout'         
"${OIDC_CONNECT_TIMEOUT:-5 secs}"
   prop_replace 'nifi.registry.security.user.oidc.read.timeout'            
"${OIDC_READ_TIMEOUT:-5 secs}"
   prop_replace 'nifi.registry.security.user.oidc.client.id'               
"${OIDC_CLIENT_ID:-}"
   prop_replace 'nifi.registry.security.user.oidc.client.secret'           
"${OIDC_CLIENT_SECRET:-}"
   prop_replace 'nifi.registry.security.user.oidc.preferred.jwsalgorithm'  
"${OIDC_PREFERRED_JWSALGORITHM:-JDK}"
   ```
   
   Thus, for instance, for the `nifi-registry` we would have:
   
   ```bash
   docker run --name nifi-registry \
     -v /path/to/tls/certs/localhost:/opt/certs \
     -p 18443:18443 \
     -e AUTH=oidc \
     -e KEYSTORE_PATH=/opt/certs/keystore.jks \
     -e KEYSTORE_TYPE=JKS \
     -e KEYSTORE_PASSWORD=QKZv1hSWAFQYZ+WU1jjF5ank+l4igeOfQRp+OSbkkrs \
     -e TRUSTSTORE_PATH=/opt/certs/truststore.jks \
     -e TRUSTSTORE_PASSWORD=rHkWR1gDNW3R9hgbeRsT3OM3Ue0zwGtQqcFKJD2EXWE \
     -e TRUSTSTORE_TYPE=JKS \
     -e INITIAL_ADMIN_IDENTITY='[email protected]' \
     -e 
OIDC_DISCOVERY_URL=https://www.gitlab.com/.well-known/openid-configuration \
     -e 
OIDC_CLIENT_ID=436cf9c691e9fb924b7b722b59a067d84fad802fa78804381b6be3d5bff44ae2 
\
     -e 
OIDC_CLIENT_SECRET=436cf9c661e9fb924a7b722b59a067d84fad802fa78804381b6be3d5bff44ae2
 \
     -d \
     apache/nifi-registry:latest
     ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to