adamdebreceni commented on code in PR #1457:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1457#discussion_r1048466865
##########
extensions/standard-processors/tests/unit/PutTCPTests.cpp:
##########
@@ -141,16 +120,16 @@ class PutTCPTestFixture {
}
size_t getNumberOfActiveSessions(std::optional<uint16_t> port =
std::nullopt) {
- if (auto session_aware_listener =
dynamic_cast<ISessionAwareServer*>(getListener(port))) {
- return session_aware_listener->getNumberOfSessions() - 1; // There is
always one inactive session waiting for a new connection
+ if (auto session_aware_listener =
dynamic_cast<CancellableTcpServer*>(getListener(port))) {
+ return session_aware_listener->getNumberOfSessions(); // There is
always one inactive session waiting for a new connection
Review Comment:
is the comment still relevant, why can we remove the `-1`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
