takraj commented on PR #6504: URL: https://github.com/apache/nifi/pull/6504#issuecomment-1353524643
> @takraj Thanks for the changes! Overall it looks good to me, except the last commit: > > > Fix constant IOException in onTrigger() when DistributedMapCache has no entries > > So there was an issue when `DistributedMapCache` was used (I tested it with Hazelcast cache and did not run into it). I debugged it a bit and the root cause seems to be that `GenericObjectSerDe.deserialize()` should handle empty byte arrays. Like in [CacheValueDeserializer](https://github.com/apache/nifi/blob/78be613a0f85b664695ea2cbfaf26163f9b8e454/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FetchDistributedMapCache.java#L287-L296). Please fix it in the deserializer instead of cacthing the exception in `onTrigger()`. > > There are also other changes in the last commit whose purpose is unclear for me: `stateBackup` handling and moving the fetcher creation into `onTrigger()` instead of `onScheduled()`. If there is no good reason for them, I would suggest reverting the whole commit and adding the `GenericObjectSerDe` fix only. @turcsanyip Done. Please re-check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
