martinzink commented on code in PR #1434:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1434#discussion_r1053416581
##########
extensions/windows-event-log/wel/WindowsEventLog.cpp:
##########
@@ -158,51 +159,59 @@ std::string
WindowsEventLogMetadataImpl::getEventData(EVT_FORMAT_MESSAGE_FLAGS f
return event_data;
}
-std::string WindowsEventLogHandler::getEventMessage(EVT_HANDLE eventHandle)
const {
+nonstd::expected<std::string, DWORD>
WindowsEventLogHandler::getEventMessage(EVT_HANDLE eventHandle) const {
Review Comment:
again thanks, its much better this way 👍
https://github.com/apache/nifi-minifi-cpp/pull/1434/commits/e142a7d9796ac63ccd4758a9e5a570dae1509fc9#diff-72a907e167b376aa07b9e4ee412b95e974d9fa89c80477a735f4c23e966038b3R75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
