fgerlits commented on code in PR #1481:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1481#discussion_r1053449250
##########
libminifi/include/core/logging/LoggerConfiguration.h:
##########
@@ -133,16 +132,21 @@ class LoggerConfiguration {
class LoggerImpl : public Logger {
public:
- explicit LoggerImpl(std::string name, const std::shared_ptr<LoggerControl>
&controller, const std::shared_ptr<spdlog::logger> &delegate)
+ explicit LoggerImpl(std::string name, std::optional<std::string> id, const
std::shared_ptr<LoggerControl> &controller, const
std::shared_ptr<spdlog::logger> &delegate)
Review Comment:
I wanted to make it generic, so we could add other kinds of stuff, but it's
true that it's already specialized to `Identifier` in `getLogger()`. Should I
change it to `Identifier` all the way, i.e. in the stored field and the return
value of `get_id()`, as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
