joewitt commented on PR #6685: URL: https://github.com/apache/nifi/pull/6685#issuecomment-1360012142
sorry about that Mark - i have been thinking ever since I saw that note before you were. My mistake. I think if tests existed you should be able to add to them. Creating tests where there are none and then having to deal with the existing untested bits is a bit much yeah. I'm fine with this as is but I do think someone more familiar with this portion of the code should review/merge. Mark's review from a functional point of view should make this super fast for someone more familiar. If not...I'll merge it and call it good soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
