exceptionfactory commented on PR #6798: URL: https://github.com/apache/nifi/pull/6798#issuecomment-1361645012
> @exceptionfactory Do you mean just asserting for example getErrorMessages on the MockComponentLog is not empty? I thought it also may be helpful to have the contents of the message similar to in the ticket > > > Error on line 17 column 5 SXXP0003: Error reported by XML parser: The element type "xsl:tomplate" must be terminated by the matching end-tag "</xsl:tomplate>". > > in order to demonstrate the issue was fixed. Asserting an exact message makes the unit test more brittle when it comes to library changes. In this particular case, asserting that the message contains the word `tomplate` seems like a good approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
