lordgamez commented on code in PR #1460:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1460#discussion_r1063609446
##########
libminifi/include/core/logging/Logger.h:
##########
@@ -72,6 +76,8 @@ inline decltype(auto) conditional_convert(const Arg& val) {
return val;
} else if constexpr (std::is_same_v<decltype(std::declval<const
Arg&>().c_str()), const char*>) {
return val.c_str();
+ } else if constexpr (std::is_same_v<decltype(std::declval<const
Arg&>().string()), std::string>) {
+ return val.string().c_str();
Review Comment:
Good catch, updated in fb658f6abd33164157570344436dddae13700823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
