Gábor Gyimesi created MINIFICPP-2028:
----------------------------------------

             Summary: Remove SerializableComponent dependency from Repository
                 Key: MINIFICPP-2028
                 URL: https://issues.apache.org/jira/browse/MINIFICPP-2028
             Project: Apache NiFi MiNiFi C++
          Issue Type: Improvement
            Reporter: Gábor Gyimesi
            Assignee: Gábor Gyimesi


core::Repository is inherited from SerializableComponent which is an unneeded 
dependency. SerializableComponent contains a lot of member functions that are 
not used in core::Repository and in multiple repository implementations these 
serialization methods aren't doing actual serialization. The serialization and 
deserialization semantics are also mixed up in these implementations.

The inheritance should be removed and the actual implementations in 
core::Repository child implementations should be renamed to reflect the actual 
functionality. Where SerializableComponent is actually implemented, for example 
in 
ProvenanceEventRecord, it should be revised to see if all Serialize/Deserialize 
overloads are needed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to