exceptionfactory commented on code in PR #6400:
URL: https://github.com/apache/nifi/pull/6400#discussion_r1064839472
##########
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java:
##########
@@ -1707,6 +1709,17 @@ public boolean isZooKeeperClientSecure() {
return Boolean.parseBoolean(clientSecure);
}
+ public boolean isZookeeperClientWithEnsembleTracker() {
+ final String defaultValue =
String.valueOf(DEFAULT_ZOOKEEPER_CLIENT_ENSEMBLE_TRACKER);
+ final String withEnsembleTracker =
getProperty(ZOOKEEPER_CLIENT_ENSEMBLE_TRACKER, defaultValue).trim();
+
+ if (!"true".equalsIgnoreCase(withEnsembleTracker) &&
!"false".equalsIgnoreCase(withEnsembleTracker)) {
Review Comment:
It looks like other `NiFiProperties` methods have different approaches for
`Boolean` handling. The method for `nifi.zookeeper.client.secure` uses this
approach, so although it is more strict, it seems acceptable under the
circumstances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
