mattyb149 commented on code in PR #6829:
URL: https://github.com/apache/nifi/pull/6829#discussion_r1064859187
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/StandardProcessorNode.java:
##########
@@ -1799,8 +1800,15 @@ private void initiateStart(final
ScheduledExecutorService taskScheduler, final l
return null;
};
- // Trigger the task in a background thread.
- final Future<?> taskFuture =
schedulingAgentCallback.scheduleTask(startupTask);
+ final Future<?> taskFuture;
+ try {
+ // Trigger the task in a background thread.
+ taskFuture = schedulingAgentCallback.scheduleTask(startupTask);
+ } catch (RejectedExecutionException rejectedExecutionException) {
+ final ValidationState validationState = getValidationState();
+ LOG.error("Unable to start {}. Last known validation state was {}
: {}", this, validationState, validationState.getValidationErrors(),
rejectedExecutionException);
+ return;
Review Comment:
Should this throw the exception instead of returning? Curious to see how the
code behaves if the exception is not thrown (does it start up "successfully"
when it was supposed to fail/crash?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
