martinzink commented on code in PR #1456:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1456#discussion_r1066964369
##########
docker/test/integration/MiNiFi_integration_test_driver.py:
##########
@@ -311,3 +311,9 @@ def check_metric_class_on_prometheus(self, metric_class,
timeout_seconds):
def check_processor_metric_on_prometheus(self, metric_class,
timeout_seconds, processor_name):
assert
self.cluster.wait_for_processor_metric_on_prometheus(metric_class,
timeout_seconds, processor_name)
+
+ def check_minimum_peak_memory_usage(self, minimum_peak_memory_usage: int,
timeout_seconds: int) -> None:
+ assert
self.cluster.wait_for_peak_memory_usage(minimum_peak_memory_usage,
timeout_seconds)
+
+ def check_maximum_memory_usage(self, maximum_memory_usage: int,
timeout_seconds: int) -> None:
+ assert self.cluster.wait_for_peak_memory_usage(maximum_memory_usage,
timeout_seconds)
Review Comment:
good catch, I've reworked this part and renamed them as well to be more
readable in
https://github.com/apache/nifi-minifi-cpp/pull/1456/commits/d08d3c78709c3a1042429de7ac18591909f6e4d2#diff-4487753f519234543da32b7926ab6cfc45c79ae2467eca71c8f6c269c7195eefR322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
