[
https://issues.apache.org/jira/browse/NIFI-11035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676757#comment-17676757
]
Daniel Stieglitz edited comment on NIFI-11035 at 1/13/23 8:39 PM:
------------------------------------------------------------------
[~exceptionfactory] There are many Groovy test files in nifi-commons which are
using Groovy's
{code:java}assert{code} method and not Junit 5 Assertions. Should they be
replaced with Junit 5 assertions?
Also I see many Groovy test files in nifi-commons using
{code:java}
groovy.test.GroovyAssert.shouldFail
{code}
should they be replaced with Junit 5 Assertions.assertThrows ?
was (Author: JIRAUSER294662):
[~exceptionfactory] There are many Groovy test files in nifi-commons which are
using Groovy's assert method and not Junit 5 Assertions. Should they be
replaced with Junit 5 assertions?
> Replace remaining JUnit 4 assertions in nifi-commons with JUnit 5 assertions
> ----------------------------------------------------------------------------
>
> Key: NIFI-11035
> URL: https://issues.apache.org/jira/browse/NIFI-11035
> Project: Apache NiFi
> Issue Type: Sub-task
> Reporter: Daniel Stieglitz
> Assignee: Daniel Stieglitz
> Priority: Minor
>
> A quick search nifi-commons for "org.junit.Assert" indicates there are over
> 50 cases where JUnit 4 assertions are still being used. These should be
> replaced with JUnit 5 assertions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
