[
https://issues.apache.org/jira/browse/NIFI-11035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676923#comment-17676923
]
David Handermann commented on NIFI-11035:
-----------------------------------------
Thanks for highlighting these additional references for upgrade [~dstiegli1]!
There is a separate epic NIFI-10047 for tracking converting Groovy tests to
Java, but as you noted, there are cases where that overlaps with upgrading to
JUnit 5. Both the Groovy {{assert}} and {{shouldFail}} assertions should be
replaced with JUnit 5. There are a number of extensive tests in
{{nifi-security-utils}} that should be refactored, but they need to be
evaluated carefully. With that background, keeping this issue focused on
changing the assertions to JUnit 5 sounds like the best approach, and separate
efforts can track the refactoring from Groovy to Java.
> Replace remaining JUnit 4 assertions in nifi-commons with JUnit 5 assertions
> ----------------------------------------------------------------------------
>
> Key: NIFI-11035
> URL: https://issues.apache.org/jira/browse/NIFI-11035
> Project: Apache NiFi
> Issue Type: Sub-task
> Reporter: Daniel Stieglitz
> Assignee: Daniel Stieglitz
> Priority: Minor
>
> A quick search nifi-commons for "org.junit.Assert" indicates there are over
> 50 cases where JUnit 4 assertions are still being used. These should be
> replaced with JUnit 5 assertions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
