szaszm commented on code in PR #1491: URL: https://github.com/apache/nifi-minifi-cpp/pull/1491#discussion_r1071096863
########## CMakeLists.txt: ########## @@ -106,7 +106,7 @@ if (WIN32) endif() if (WIN32) - add_definitions(-DSERVICE_NAME="Apache NiFi MINiFi") + add_definitions(-DMINIFI_SERVICE_NAME="Apache NiFi MINiFi") Review Comment: Thanks for the explanation and the change. I like the scoped version more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
