adamdebreceni commented on code in PR #1466: URL: https://github.com/apache/nifi-minifi-cpp/pull/1466#discussion_r1073615926
########## libminifi/test/TestBase.cpp: ########## @@ -564,7 +588,7 @@ std::unique_ptr<minifi::Connection> TestPlan::buildFinalConnection(const std::sh std::stringstream connection_name; connection_name << processor->getUUIDStr() << "-to-" << processor->getUUIDStr(); auto connection = std::make_unique<minifi::Connection>(flow_repo_, content_repo_, connection_name.str()); - connection->addRelationship(termination_); + connection->addRelationship(termination_.value()); Review Comment: in theory `buildFinalConnection` is only called when `termination_` is set, added `gsl_Expects` to verify this precondition -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
