exceptionfactory commented on code in PR #6847:
URL: https://github.com/apache/nifi/pull/6847#discussion_r1081685160
##########
nifi-docker/dockerhub/sh/start.sh:
##########
@@ -97,6 +97,13 @@ prop_replace
'nifi.analytics.connection.model.implementation' "${NIFI_ANALYTIC
prop_replace 'nifi.analytics.connection.model.score.name'
"${NIFI_ANALYTICS_MODEL_SCORE_NAME:-rSquared}"
prop_replace 'nifi.analytics.connection.model.score.threshold'
"${NIFI_ANALYTICS_MODEL_SCORE_THRESHOLD:-.90}"
+# Add NAR provider properties
+# nifi-registry NAR provider
+if [ -n "${NIFI_NAR_LIBRARY_PROVIDER_NIFI_REGISTRY_URL}" ]; then
+ prop_add 'nifi.nar.library.provider.nifi-registry.implementation'
'org.apache.nifi.registry.extension.NiFiRegistryNarProvider'
Review Comment:
The `NiFiRegistryNarProvider` was deprecated in favor of
`NiFiRegistryExternalResourceProvider` as of NiFi 1.17.0 as part of
[NIFI-9615](https://issues.apache.org/jira/browse/NIFI-9615). It looks like
this could be replaced with the new class.
```suggestion
prop_add 'nifi.nar.library.provider.nifi-registry.implementation'
'org.apache.nifi.registry.extension.NiFiRegistryExternalResourceProvider'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
