ChrisSamo632 commented on PR #6881: URL: https://github.com/apache/nifi/pull/6881#issuecomment-1401525011
Thanks for the fix @exceptionfactory, I've built and run (in "Single User Auth" mode) with Java 11 and confirmed the produced `truststore.p12` file is usable by Java 11's `keytool`. I couldn't do this with a Docker Image (per the original NiFi Ticket) as I'm using an `arm64` based machine and the Docker Maven scripts don't currently work on this architecture, but I think building/running/checking natively should be sufficient. If I get chance I'll try the image on an `amd64` machine, but likely that won't be until later in the week (unless someone can build and push the images to a repo earlier as @kevdoran did for the 1.19.0-SNAPSHOT when making tjhe images work for `arm64`?) My only question is whether we should change the [DEFAULT_KEY_STORE_TYPE](https://github.com/apache/nifi/blob/c29443d4826e43f3a79ae6bb2fe26404296e2b6e/nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/toolkit/tls/configuration/TlsConfig.java#L29) to `pkcs12` now or if that would be too disruptive (people expecting JKS files through Toolkit suddenly getting PKCS12s unless they know to update their commands with the `-T` flag - could be a Migration Guide addition?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
