martinzink commented on code in PR #1457:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1457#discussion_r1085089692
##########
libminifi/test/Catch.h:
##########
@@ -40,4 +40,46 @@ struct StringMaker<std::nullopt_t> {
return "std::nullopt";
}
};
+
+template <>
+struct StringMaker<std::error_code> {
+ static std::string convert(const std::error_code& error_code) {
+ return fmt::format("std::error_code(value:{}, message:{})",
error_code.value(), error_code.message());
+ }
+};
} // namespace Catch
+
+namespace org::apache::nifi::minifi::test {
+struct MatchesSuccess : Catch::MatcherBase<std::error_code> {
+ MatchesSuccess() = default;
+
+ bool match(const std::error_code& err) const override {
+ return err.value() == 0;
+ }
+
+ std::string describe() const override {
+ return fmt::format("== {}",
Catch::StringMaker<std::error_code>::convert(std::error_code{}));
+ }
+};
+
+struct MatchesError : Catch::MatcherBase<std::error_code> {
+ explicit MatchesError(std::optional<std::error_code> expected_error =
std::nullopt)
+ : Catch::MatcherBase<std::error_code>(),
+ expected_error_(expected_error) {
+ }
+
+ bool match(const std::error_code& err) const override {
+ if (expected_error_)
+ return err.value() == expected_error_->value();
Review Comment:
Good idea, :+1: changed it in
https://github.com/apache/nifi-minifi-cpp/pull/1457/commits/f37cffb3fe783683d38646b198dfc38f7a439ce4#diff-2443fe4ee36121fb137afe4324fd0b376b91b1acdff7aa9e5cd28862f619a447R73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
