szaszm commented on code in PR #1457:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1457#discussion_r1073490689
##########
extensions/standard-processors/processors/PutTCP.cpp:
##########
@@ -130,17 +146,19 @@ void PutTCP::onSchedule(core::ProcessContext* const
context, core::ProcessSessio
idle_connection_expiration_.reset();
if (auto timeout = context->getProperty<core::TimePeriodValue>(Timeout);
timeout && timeout->getMilliseconds() > 0ms)
- timeout_ = timeout->getMilliseconds();
+ timeout_duration_ = timeout->getMilliseconds();
else
- timeout_ = 15s;
+ timeout_duration_ = 15s;
std::string context_name;
- ssl_context_service_.reset();
+ ssl_context_.reset();
if (context->getProperty(SSLContextService.getName(), context_name) &&
!IsNullOrEmpty(context_name)) {
if (auto controller_service = context->getControllerService(context_name))
{
- ssl_context_service_ =
std::dynamic_pointer_cast<minifi::controllers::SSLContextService>(context->getControllerService(context_name));
- if (!ssl_context_service_)
+ if (auto ssl_context_service =
std::dynamic_pointer_cast<minifi::controllers::SSLContextService>(context->getControllerService(context_name)))
{
+ ssl_context_ = getSslContext(ssl_context_service);
+ } else {
logger_->log_error("%s is not a SSL Context Service", context_name);
+ }
Review Comment:
It might be better to throw and avoid running without TLS if the
SSLContextService is specified but invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
