martinzink commented on code in PR #1474:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1474#discussion_r1085109599
##########
libminifi/include/SchedulingAgent.h:
##########
@@ -90,14 +86,15 @@ class SchedulingAgent {
logger_->log_trace("Destroying scheduling agent");
}
- // onTrigger, return whether the yield is need
- bool onTrigger(core::Processor* processor, const
std::shared_ptr<core::ProcessContext> &processContext, const
std::shared_ptr<core::ProcessSessionFactory> &sessionFactory);
- // start
+ nonstd::expected<void, std::exception_ptr> onTrigger(core::Processor*
processor,
+ const
std::shared_ptr<core::ProcessContext>& process_context,
+ const
std::shared_ptr<core::ProcessSessionFactory>& session_factory);
Review Comment:
sry for the late reply I've fixed this alignment in
https://github.com/apache/nifi-minifi-cpp/pull/1474/commits/fa5f54e54592e0ec7c4c46fdebe40d1ed559d56d
##########
libminifi/include/CronDrivenSchedulingAgent.h:
##########
@@ -45,8 +45,6 @@ class CronDrivenSchedulingAgent : public
ThreadedSchedulingAgent {
: ThreadedSchedulingAgent(controller_service_provider, std::move(repo),
std::move(flow_repo), std::move(content_repo), std::move(configuration),
thread_pool) {
}
- CronDrivenSchedulingAgent(const CronDrivenSchedulingAgent& parent) = delete;
- CronDrivenSchedulingAgent& operator=(const CronDrivenSchedulingAgent&
parent) = delete;
Review Comment:
No, this is already disabled in the parent class see related conversation:
https://github.com/apache/nifi-minifi-cpp/pull/1474#discussion_r1049662610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
