exceptionfactory commented on PR #6821: URL: https://github.com/apache/nifi/pull/6821#issuecomment-1402036808
Thanks for the thorough testing and feedback @greyp9! In response to your notes: 1. I agree that including some additional documentation for these Processors describing the mapping between configuration settings would be helpful. Creating additional details documents for these two Processors seems like a good starting location. There is more general encryption documentation in the Administrator's Guide, which could be updated separately when we are ready to deprecate the EncryptContent Processor. 2. The EncryptContent FlowFile attributes were at one time intended to support simplified integration, but that was never completed implemented. The Initialization Vector cannot be configured in the DecryptContent Processors, and both expect to read it from the FlowFile content. For these reasons, I don't think it is necessary to remove any of the attributes that EncryptContent applies. 3. The EncryptionMethod values have retained their current order for a long time, so I think those should remain unchanged. However, I agree that the values for DecryptContentCompatibilityMode should be alphabetized, so I will make those changes. 4. The jasypt dependency is not actually used, so I created [NIFI-11090](https://issues.apache.org/jira/browse/NIFI-11090) to remove the dependency. 5. With the DecryptContent Processors, any raw hexadecimal key must match the value used for encryption. Adding a note might be helpful as a follow on effort, but I'm not sure it is particularly helpful given that it should already be known, otherwise decryption will fail. 6. I considered having separate properties versus sharing the same property and interpreting it based on the `Key Specification Format` property. I would not expect the value and format to change in normal usage, so it seems more straightforward to keep the current approach, as opposed to introducing a separate property. If you think it would be significantly better to have a separate property, and have both properties depend on the format property, I can look at making those changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
