[
https://issues.apache.org/jira/browse/NIFI-11108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683165#comment-17683165
]
Daniel Stieglitz edited comment on NIFI-11108 at 2/3/23 3:01 PM:
-----------------------------------------------------------------
[~exceptionfactory] I was able to refactor many of the remaining classes under
nifi/nifi-nar-bundles to use JUnit 5 but these were the following I was not
able to.
{code:java}
nifi/nifi-nar-bundles/nifi-ldap-iaa-providers-bundle/nifi-ldap-iaa-providers/src/test/java/org/apache/nifi/ldap/tenants/LdapUserGroupProviderTest.java
{code} as it uses a JUnit 4 runner FrameworkRunner which has no known Junit5
extension equivalent.
{code:java}
nifi/nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/test/java/org/apache/nifi/processors/kudu/ITPutKudu.java
nifi/nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-controller-service/src/test/java/org/apache/nifi/controller/kudu/ITestKuduLookupService.java
{code} as they use KuduTestHarness which utilizes a Junit 4 Rule.
{code:java}
nifi/nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/test/java/org/apache/nifi/processors/windows/event/log/JNAOverridingJUnitRunner.java
nifi/nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/test/java/org/apache/nifi/processors/windows/event/log/ConsumeWindowsEventLogFailTest.java
nifi/nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/test/java/org/apache/nifi/processors/windows/event/log/ConsumeWindowsEventLogTest.java
nifi/nilogfi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event--processors/src/test/java/org/apache/nifi/processors/windows/event/log/jna/ErrorLookupTest
nifi/nilogfi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event--processors/src/test/java/org/apache/nifi/processors/windows/event/log/jna/EventSubscribeXmlRenderingCallbackTest
{code} as detailed in NIFI-9164
was (Author: JIRAUSER294662):
[~exceptionfactory] I was able to refactor many of the remaining classes under
nifi/nifi-nar-bundles to use JUnit 5 but these were the following I was not
able to.
{code:java}
nifi/nifi-nar-bundles/nifi-ldap-iaa-providers-bundle/nifi-ldap-iaa-providers/src/test/java/org/apache/nifi/ldap/tenants/LdapUserGroupProviderTest.java
{code} as it uses a JUnit 4 runner FrameworkRunner which has no known Junit5
extension equivalent.
{code:java}
nifi/nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/test/java/org/apache/nifi/processors/kudu/ITPutKudu.java
nifi/nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-controller-service/src/test/java/org/apache/nifi/controller/kudu/ITestKuduLookupService.java
nifi/nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/test/java/org/apache/nifi/processors/kudu/ITPutKudu.java
{code} as they use KuduTestHarness which utilizes a Junit 4 Rule.
{code:java}
nifi/nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/test/java/org/apache/nifi/processors/windows/event/log/JNAOverridingJUnitRunner.java
nifi/nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/test/java/org/apache/nifi/processors/windows/event/log/ConsumeWindowsEventLogFailTest.java
nifi/nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/test/java/org/apache/nifi/processors/windows/event/log/ConsumeWindowsEventLogTest.java
nifi/nilogfi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event--processors/src/test/java/org/apache/nifi/processors/windows/event/log/jna/ErrorLookupTest
nifi/nilogfi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event--processors/src/test/java/org/apache/nifi/processors/windows/event/log/jna/EventSubscribeXmlRenderingCallbackTest
{code} as detailed in NIFI-9164
> Refactor remaining JUnit 4 tests under nifi/nifi-nar-bundles to JUnit 5
> -----------------------------------------------------------------------
>
> Key: NIFI-11108
> URL: https://issues.apache.org/jira/browse/NIFI-11108
> Project: Apache NiFi
> Issue Type: Sub-task
> Reporter: Daniel Stieglitz
> Assignee: Daniel Stieglitz
> Priority: Minor
> Fix For: 1.20.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> A search for
> {code:java}
> org.junit.Test
> {code}
> in nifi/nifi-nar-bundles indicates there are still 23 tests using Junit 4.
> And a search for
> {code:java}
> org.junit.Assert
> {code}
> indicates there are over 100 imports of this class.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
