nandorsoma opened a new pull request, #6930: URL: https://github.com/apache/nifi/pull/6930
<!-- Licensed to the Apache Software Foundation (ASF) under one or more --> <!-- contributor license agreements. See the NOTICE file distributed with --> <!-- this work for additional information regarding copyright ownership. --> <!-- The ASF licenses this file to You under the Apache License, Version 2.0 --> <!-- (the "License"); you may not use this file except in compliance with --> <!-- the License. You may obtain a copy of the License at --> <!-- http://www.apache.org/licenses/LICENSE-2.0 --> <!-- Unless required by applicable law or agreed to in writing, software --> <!-- distributed under the License is distributed on an "AS IS" BASIS, --> <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> <!-- See the License for the specific language governing permissions and --> <!-- limitations under the License. --> # Summary [NIFI-11144](https://issues.apache.org/jira/browse/NIFI-11144) As the title says, this PR intends to fix currently failing tests without changing the behavior of the processors. There are two things worth mentioning. There was an exception propagation in ConsumeJMS. The comment next to it doesn't really make sense. In 2020 a commit was added, which even caught all exceptions in the Abstract class. I tried to figure out what the expectation would be. Propagate it according to the original behavior, or go forward and remove the rethrow part. I decided to do the latter because propagating the exception doesn't make sense in this case. There is no upstream connection, and when "consume" fails, there won't be a flowfile in the output relationship, so rollback is unnecessary, which could be triggered by the exception. The other thing is testMultiplethreads(). It failed with timeout because we reached a limit after publishing a thousand messages. It is probably related to [this](https://activemq.apache.org/how-to-deal-with-large-number-of-threads-in-clients). I tried multiple different configurations without luck. It is a hint, but maybe not all of them work with the test broker implementation. Ultimately I decided to set the total messages to that threshold. This way, we can spare the additional configuration, and one thousand messages should be enough for the purpose of the test. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
