markap14 commented on code in PR #6937:
URL: https://github.com/apache/nifi/pull/6937#discussion_r1102039621
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/flow/synchronization/StandardVersionedComponentSynchronizer.java:
##########
@@ -667,6 +682,8 @@ private Set<String> updateConnectionDestinations(final
ProcessGroup group, final
newDestination == null
||
(newDestination.getConnectableType() ==
ConnectableType.OUTPUT_PORT &&
!newDestination.getProcessGroup().equals(connection.getProcessGroup()))
+ ||
+ (newDestination.getConnectableType() ==
ConnectableType.INPUT_PORT &&
!connection.getDestination().getVersionedComponentId().get().equals(proposedConnection.getDestination().getId())
&&
connection.getDestination().getName().equals(proposedConnection.getDestination().getName()))
Review Comment:
I could be wrong, but I'm pretty sure that this block of code is not
actually necessary. We don't need to handle this case specially, as far as I
can tell. Unless there's something that I'm missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
