Lehel44 commented on PR #6935: URL: https://github.com/apache/nifi/pull/6935#issuecomment-1431523294
Thanks for the related reviews to this PR @exceptionfactory @turcsanyip. With a more general approach I refactored the AbstractDBCPConnectionPool to be more generic and flexible. - I moved the PropertyDescriptors to a different class to avoid unnecessary inheritance. - I kept parts that is currently being reused and can be reused in the abstract super class - Moved domain specific code to the extending subclasses - Created DataSourceConfiguration to decouple PropertyDescriptors and DataSource configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
