nandorsoma commented on PR #6969:
URL: https://github.com/apache/nifi/pull/6969#issuecomment-1436033324

   > @markap14 This looks consistent with the docs but wanted to check with you 
since it could affect files landing in each node
   
   Thanks for looking at it [@mattyb149](https://github.com/mattyb149)! Just a 
little more info. I noticed after opening the PR that when the processor is 
[listing a local 
directory](https://github.com/apache/nifi/blob/a63c3594c9dbbbbd1afcb0844b7ab0e1c3e6f171/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java#L135),
 it may work on multiple nodes while it is guaranteed that the local directory 
contains different files on each node. In that situation, the state is stored 
locally, so it doesn't matter whether the primary node changes. If I'm right, 
this pr is not acceptable. Instead, we could update the description accordingly 
and add a validation (of possible) that prevents using the processor on all 
nodes when the `Input Directory Location` is set to `Local`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to