szaszm commented on code in PR #1490:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1490#discussion_r1115782479
##########
libminifi/include/core/Repository.h:
##########
@@ -54,28 +54,22 @@ constexpr auto MAX_REPOSITORY_STORAGE_SIZE = 10_MiB;
constexpr auto MAX_REPOSITORY_ENTRY_LIFE_TIME = std::chrono::minutes(10);
constexpr auto REPOSITORY_PURGE_PERIOD = std::chrono::milliseconds(2500);
-class Repository : public core::CoreComponent {
+class Repository : public core::ReportableRepository {
Review Comment:
Looks good. Forgot to mention the design principle behind my recommendation:
[Interface Segregation
Principle](https://en.wikipedia.org/wiki/Interface_segregation_principle) (I in
SOLID)
Whoever depends on `RepositoryMetricsSource` does not need to depend on
`CoreComponent`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
