nandorsoma opened a new pull request, #6987: URL: https://github.com/apache/nifi/pull/6987
<!-- Licensed to the Apache Software Foundation (ASF) under one or more --> <!-- contributor license agreements. See the NOTICE file distributed with --> <!-- this work for additional information regarding copyright ownership. --> <!-- The ASF licenses this file to You under the Apache License, Version 2.0 --> <!-- (the "License"); you may not use this file except in compliance with --> <!-- the License. You may obtain a copy of the License at --> <!-- http://www.apache.org/licenses/LICENSE-2.0 --> <!-- Unless required by applicable law or agreed to in writing, software --> <!-- distributed under the License is distributed on an "AS IS" BASIS, --> <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> <!-- See the License for the specific language governing permissions and --> <!-- limitations under the License. --> # Summary [NIFI-11137](https://issues.apache.org/jira/browse/NIFI-11137) The original goal of this PR is to add record support to Consume/PublishJMS processors. However, it adds a bit more. Record processing comes with a significant amount of boilerplate code, which varies slightly between processors. As far as I can tell, this difference most of the time has nothing to do with the processor's requirements, but it is related to when it was written and what was the accepted approach at that time. In addition to that, responsibilities are not well separated in such code. Often record reading, writing, provenance event, counter, and business logic handling can be observed in the same method. Because of that, it is not that easy to deal with them. I tried to come up with a generic concept for the above problems. This is what can be found under the `strategy` package. The concept revolves around the nature of the processor. Hence the naming `MessagePublisher/Consumer`. I didn't want to modify the existing behavior of the jms processor around single message processing, but this concept can support single message processing too. Now, it is just a vision, but it enables us to configure the `MessagePublisher/Consumer` in the `@OnSchedule` method based on whether we want standard or record processing, eliminating the need of `if(record) { doRecordProcessing } else { doStandardProcessing }` in the `onTrigger` method. I'm curious about your thoughts, and I'm looking forward to your advice! I'm sure there will be, at least in the naming. If you like the idea, my goal would be to improve it either in this pr or in a following one depending on the nature of the change. But it would stay in the current bundle. When it is ready, it could be moved to a common bundle so other processors can rely on it. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
