[ 
https://issues.apache.org/jira/browse/NIFI-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15684348#comment-15684348
 ] 

ASF GitHub Bot commented on NIFI-2750:
--------------------------------------

Github user mattyb149 commented on the issue:

    https://github.com/apache/nifi/pull/1001
  
    +1 LGTM, ran unit tests and tested with MySQL, verified the default 
behavior is preserved, and column names are quoted correctly when specified.  
Thank you for the contribution! Merging to master


> Add Optional Column Name Quoting to ConvertJSONToSQL
> ----------------------------------------------------
>
>                 Key: NIFI-2750
>                 URL: https://issues.apache.org/jira/browse/NIFI-2750
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 1.0.0
>            Reporter: Peter Wicks
>            Assignee: Peter Wicks
>            Priority: Minor
>
> If a column name happens to also be a SQL reserved word then the SQL 
> generated by ConvertJSONToSQL will be invalid and will fail when it runs.
> By getting and quoting column identifiers (optionally) it will allow users to 
> keep original column names by quoting them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to