fgerlits commented on code in PR #1518:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1518#discussion_r1121342991
##########
extensions/standard-processors/processors/ListFile.h:
##########
@@ -81,19 +81,15 @@ class ListFile : public core::Processor {
private:
struct ListedFile : public utils::ListedObject {
[[nodiscard]] std::chrono::time_point<std::chrono::system_clock>
getLastModified() const override {
- return
std::chrono::time_point_cast<std::chrono::milliseconds>(utils::file::FileUtils::to_sys(last_modified_time));
+ return last_modified_time;
}
[[nodiscard]] std::string getKey() const override {
- return absolute_path.string();
+ return full_file_path.string();
}
- std::filesystem::path filename;
- std::filesystem::path absolute_path;
- std::filesystem::file_time_type last_modified_time;
- std::filesystem::path relative_path;
+ std::chrono::time_point<std::chrono::system_clock> last_modified_time;
Review Comment:
`ListedFile::getLastModified()` used to convert the `file_time_type` to
`time_point<system_clock>` before storing it in the state manager. Now we do
this conversion earlier, but the stored data doesn't change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
