lordgamez commented on code in PR #1519:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1519#discussion_r1123097109
##########
libminifi/src/core/ContentRepository.cpp:
##########
@@ -60,16 +60,29 @@ void ContentRepository::incrementStreamCount(const
minifi::ResourceClaim &stream
}
}
+void ContentRepository::removeFromPurgeList() {
+ for (auto it = purge_list_.begin(); it != purge_list_.end();) {
+ if (removeKey(*it)) {
+ purge_list_.erase(it++);
+ } else {
+ ++it;
+ }
+ }
+}
Review Comment:
It depends if we expect any persistent issues that have to be dealt with. My
thinking was that we are creating this list for any temporary issues that
should be resolved in a few tries, and it should only affect a small number of
entries. In case of a restart I think the `clearOrphans` mechanism should
remove the entries we did not manage to delete before, maybe if that fails
those can be added to the purge list for handling them later. What do you
think? Should we discuss this with the team?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
