NissimShiman opened a new pull request, #7009: URL: https://github.com/apache/nifi/pull/7009
<!-- Licensed to the Apache Software Foundation (ASF) under one or more --> <!-- contributor license agreements. See the NOTICE file distributed with --> <!-- this work for additional information regarding copyright ownership. --> <!-- The ASF licenses this file to You under the Apache License, Version 2.0 --> <!-- (the "License"); you may not use this file except in compliance with --> <!-- the License. You may obtain a copy of the License at --> <!-- http://www.apache.org/licenses/LICENSE-2.0 --> <!-- Unless required by applicable law or agreed to in writing, software --> <!-- distributed under the License is distributed on an "AS IS" BASIS, --> <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> <!-- See the License for the specific language governing permissions and --> <!-- limitations under the License. --> # Summary [NIFI-4718](https://issues.apache.org/jira/browse/NIFI-4718) This allows IdentityMimeType processor to grant flowfile v3 to have mime precedence over internal file contents Priority was raised to "70" to handle .wmv files (see [NIFI-11166](https://issues.apache.org/jira/browse/NIFI-11166) for similar issue. wmv files have priority of "60" [1], so this needed to be higher) Unit tests were expanded to cover new mime type (xhtml) mentioned in jira ticket. Looked to cover wmv as well, but when looking for free samples, most hosting websites had limits on their terms of use which causes complications. The best I could find were the four top wmv files here: https://www.appsloveworld.com/sample-wmv-video-file-free-download These are wmv trailer adaptations of the [Durian Open Movie Project](https://durian.blender.org/about/) © copyright Blender Foundation | [durian.blender.org](https://durian.blender.org/) This is under the [Creative Commons Attribution 3.0](http://creativecommons.org/licenses/by/3.0/) license [2] so we are allowed to have it to our machines. Still unclear about wrapping it into a github commit for apache nifi, though, but it can be tested as follows: Set up flow: GetFile -> MergeContent -> IdentifyMimeType -> funnel where GetFile is getting a .wmv video file. MergeContent should have Merge Format as "FlowFile Stream, v3" Output flowfile will have mime.type of video/x-ms-wmv as opposed to application/flowfile-v3 [1]https://github.com/apache/tika/blob/2.7.0/tika-core/src/main/resources/org/apache/tika/mime/tika-mimetypes.xml#L7889 [2] https://durian.blender.org/sharing/ # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
