fgerlits commented on code in PR #1524:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1524#discussion_r1126137730
##########
thirdparty/paho-mqtt/cmake-openssl.patch:
##########
@@ -0,0 +1,26 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 7bfee10..5debc1f 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -23,7 +23,7 @@ MESSAGE(STATUS "CMake version: " ${CMAKE_VERSION})
+ MESSAGE(STATUS "CMake system name: " ${CMAKE_SYSTEM_NAME})
+
+ SET(CMAKE_SCRIPTS "${CMAKE_SOURCE_DIR}/cmake")
+-SET(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/modules")
++list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/modules")
+
+ ## build settings
+ file(READ version.major PAHO_VERSION_MAJOR)
+diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
+index 0bc7194..5d35b17 100644
+--- a/src/CMakeLists.txt
++++ b/src/CMakeLists.txt
+@@ -187,7 +187,7 @@ INSTALL(FILES MQTTAsync.h MQTTClient.h
MQTTClientPersistence.h MQTTProperties.h
+
+ IF (PAHO_WITH_SSL)
+ SET(OPENSSL_ROOT_DIR "" CACHE PATH "Directory containing OpenSSL
libraries and includes")
+- find_package(OpenSSL REQUIRED)
++ # find_package(OpenSSL REQUIRED)
+
+ IF (PAHO_BUILD_SHARED)
+ ## common compilation for libpaho-mqtt3cs and libpaho-mqtt3as
Review Comment:
I don't think this part is needed: with the fixed `CMAKE_MODULE_PATH`, CMake
will find our custom `FindOpenSSL.cmake` module. With just the `SET -> list
APPEND` change, we have a chance of getting this fix accepted upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
