martinzink commented on code in PR #1504: URL: https://github.com/apache/nifi-minifi-cpp/pull/1504#discussion_r1126981510
########## extensions/python/types/PyProcessor.cpp: ########## @@ -0,0 +1,127 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "PyProcessor.h" +#include <string> +#include "PyException.h" +#include "Types.h" + +extern "C" { +namespace org::apache::nifi::minifi::extensions::python { + +static PyMethodDef PyProcessor_methods[] = { + {"setSupportsDynamicProperties", (PyCFunction) PyProcessor::setSupportsDynamicProperties, METH_VARARGS, nullptr}, + {"setDescription", (PyCFunction) PyProcessor::setDescription, METH_VARARGS, nullptr}, + {"addProperty", (PyCFunction) PyProcessor::addProperty, METH_VARARGS, nullptr}, + {} /* Sentinel */ +}; + +static PyType_Slot PyProcessorTypeSpecSlots[] = { + {Py_tp_dealloc, reinterpret_cast<void*>(pythonAllocatedInstanceDealloc<PyProcessor>)}, + {Py_tp_init, reinterpret_cast<void*>(PyProcessor::init)}, + {Py_tp_methods, reinterpret_cast<void*>(PyProcessor_methods)}, + {Py_tp_new, reinterpret_cast<void*>(newPythonAllocatedInstance<PyProcessor>)}, + {} /* Sentinel */ +}; + +static PyType_Spec PyProcessorTypeSpec{ + .name = "minifi_native.Processor", + .basicsize = sizeof(PyProcessor), + .itemsize = 0, + .flags = Py_TPFLAGS_DEFAULT, + .slots = PyProcessorTypeSpecSlots +}; + +int PyProcessor::init(PyProcessor* self, PyObject* args, PyObject*) { + PyObject* weak_ptr_capsule = nullptr; + if (!PyArg_ParseTuple(args, "O", &weak_ptr_capsule)) { + return -1; + } + + auto processor = PyCapsule_GetPointer(weak_ptr_capsule, HeldTypeName); + if (!processor) + throw PyException(); + self->processor_ = *static_cast<HeldType*>(processor); + return 0; +} + +PyObject* PyProcessor::setSupportsDynamicProperties(PyProcessor* self, PyObject*) { + auto processor = self->processor_.lock(); + if (!processor) { + PyErr_SetString(PyExc_AttributeError, "tried reading processor outside 'on_trigger'"); + Py_RETURN_NONE; + } + + processor->setSupportsDynamicProperties(); + Py_RETURN_NONE; +} + +PyObject* PyProcessor::setDescription(PyProcessor* self, PyObject* args) { + auto processor = self->processor_.lock(); + if (!processor) { + PyErr_SetString(PyExc_AttributeError, "tried reading processor outside 'on_trigger'"); + Py_RETURN_NONE; + } + + const char* description; + if (!PyArg_ParseTuple(args, "s", &description)) { + throw PyException(); + } + processor->setDescription(std::string(description)); + Py_RETURN_NONE; +} + +namespace { +bool getBoolFromTuple(PyObject* tuple, Py_ssize_t location) { + auto object = PyTuple_GetItem(tuple, location); + + if (!object) + throw PyException(); + + if (object == Py_True) + return true; + if (object == Py_False) + return false; + throw std::invalid_argument(fmt::format("{} is expected to be Py_True({}) or Py_False({})", fmt::ptr(object), fmt::ptr(Py_True), fmt::ptr(Py_False))); Review Comment: good idea, I've changed it in https://github.com/apache/nifi-minifi-cpp/pull/1504/commits/5404b7148fba7f3afd6048621b3b2fc460d905c7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
