joewitt commented on code in PR #6993:
URL: https://github.com/apache/nifi/pull/6993#discussion_r1128484574
##########
nifi-stateless/nifi-stateless-bundle/nifi-stateless-engine/src/main/java/org/apache/nifi/stateless/engine/StatelessFlowManager.java:
##########
@@ -270,10 +271,9 @@ public FlowFileQueue createFlowFileQueue(final
LoadBalanceStrategy loadBalanceSt
public ReportingTaskNode createReportingTask(final String type, final
String id, final BundleCoordinate bundleCoordinate, final Set<URL>
additionalUrls, final boolean firstTimeAdded,
final boolean register, final
String classloaderIsolationKey) {
- if (type == null || id == null || bundleCoordinate == null) {
Review Comment:
Yeah I'd not change this since while the code is cleaner it is also far less
effective in conveying intent to the user. Ultimately that is our desire given
this block of code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
