exceptionfactory commented on code in PR #4901:
URL: https://github.com/apache/nifi/pull/4901#discussion_r1129697755
##########
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-2-6-processors/src/main/java/org/apache/nifi/record/sink/kafka/KafkaRecordSink_2_6.java:
##########
@@ -160,6 +165,7 @@ public class KafkaRecordSink_2_6 extends
AbstractControllerService implements Ka
private volatile long maxAckWaitMillis;
private volatile String topic;
private volatile Producer<byte[], byte[]> producer;
+ private final Queue<Future<RecordMetadata>> ackQ = new LinkedList<>();
Review Comment:
Introducing this queue as a member variable seems like it could cause issues
when multiple components are using the same RecordSink. Moving this queue to a
method-local variable should avoid the potential for mixing up messages from
different callers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
