lordgamez commented on code in PR #1490:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1490#discussion_r1132246692
##########
libminifi/src/core/repository/VolatileRepository.cpp:
##########
@@ -71,6 +71,9 @@ bool VolatileRepository::Put(const std::string& key, const
uint8_t *buf, size_t
}
} while (!updated);
repo_data_.current_size += size;
+ if (repo_data_.current_entry_count < repo_data_.max_count) {
+ ++repo_data_.current_entry_count;
Review Comment:
If we store the `max_count` number of entries even if a new entry is added
it overwrites the old entry in a round robin fashion, so if we reach the
maximum number of entries we should not increase the value. The size seems to
be reduced with the reclaimed size beforehand, but it's also only an estimate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
