turcsanyip commented on PR #7076:
URL: https://github.com/apache/nifi/pull/7076#issuecomment-1482014568

   @malthe Thanks for working on this feature, it would be a valuable addition 
in `ConsumeAzureEventHub`.
   
   I tried out the processor and also had a look at the code.
   
   There is an essential issue with the new component state strategy: it does 
not handle the partition ownership.
   Please note, not only the checkpoints but also the ownership info is need to 
be handled and stored by a `CheckpointStore` implementation. An example can be 
found in 
[BlobCheckpointStore](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/eventhubs/azure-messaging-eventhubs-checkpointstore-blob/src/main/java/com/azure/messaging/eventhubs/checkpointstore/blob/BlobCheckpointStore.java).
   If you run the processor on a NiFi cluster, all nodes will own and process 
all partitions but the partitions should be load-balanced among the consumer 
group members (instances of the same `ConsumeAzureEventHub` processor on the 
cluster nodes).
   
   Also the processor cannot be stopped cleanly but throws 
NullPointerExceptions in a loop after Stop.
   
   Please fix these first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to