[
https://issues.apache.org/jira/browse/MINIFICPP-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Zink updated MINIFICPP-2074:
-----------------------------------
Description:
Currently we have mixed validation for time-period like properties. Some has
time-period validators (which require explicit units) and some have simple
integer validators (which require no units).
One approach would be to use time-period validators everywhere, but that could
break compatibility with thirdparty C2 servers, and NiFi/MiNiFi Java also has
this problem.
Another approach would be to fix the configuration during minifi startup, to
fix the property based on the configured validator. This would mean a
time-period validated property would change from "100" to "100 ms" on startup
and an integer validated property would change from "1min to 60000" on startup.
was:
We are sending UNSIGNED_INT_VALIDATOR for nifi_c2_agent_heartbeat_period on C2
but we are actually parsing it as a time period. (and accepting integers as
well (implicetly converted for ms)
It should be more consistent than this...
> Fix time-period/integer validated properties
> --------------------------------------------
>
> Key: MINIFICPP-2074
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2074
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: Marton Szasz
> Assignee: Martin Zink
> Priority: Major
>
> Currently we have mixed validation for time-period like properties. Some has
> time-period validators (which require explicit units) and some have simple
> integer validators (which require no units).
> One approach would be to use time-period validators everywhere, but that
> could break compatibility with thirdparty C2 servers, and NiFi/MiNiFi Java
> also has this problem.
> Another approach would be to fix the configuration during minifi startup, to
> fix the property based on the configured validator. This would mean a
> time-period validated property would change from "100" to "100 ms" on startup
> and an integer validated property would change from "1min to 60000" on
> startup.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
