lordgamez commented on code in PR #1540:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1540#discussion_r1150134013
##########
extensions/rocksdb-repos/RocksDbRepository.cpp:
##########
@@ -20,22 +20,22 @@ using namespace std::literals::chrono_literals;
namespace org::apache::nifi::minifi::core::repository {
-void RocksDbRepository::printStats() {
+std::optional<RepositoryMetricsSource::RocksDbStats>
RocksDbRepository::getRocksDbStats() const {
+ RocksDbStats stats;
auto opendb = db_->open();
if (!opendb) {
- return;
+ return stats;
Review Comment:
I returned the default 0 values when the repository is RocksDB based, but
the values are not available at the moment. I returned `std::nullopt` in
repositories that are not RocksDB based.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
