fgerlits commented on code in PR #1503:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1503#discussion_r1151582182
##########
controller/MiNiFiController.cpp:
##########
@@ -15,57 +15,52 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-#include <fcntl.h>
-#include <cstdio>
-#include <semaphore.h>
-#include <csignal>
#include <vector>
-#include <queue>
-#include <map>
#include <iostream>
-#include "core/Core.h"
-
-#include "core/FlowConfiguration.h"
-#include "core/ConfigurationFactory.h"
-#include "core/RepositoryFactory.h"
-#include "FlowController.h"
#include "MainHelper.h"
#include "properties/Configure.h"
#include "Controller.h"
#include "c2/ControllerSocketProtocol.h"
+#include "core/controller/ControllerService.h"
+#include "core/extension/ExtensionManager.h"
+#include "io/StreamFactory.h"
+#include "core/ConfigurationFactory.h"
#include "cxxopts.hpp"
namespace minifi = org::apache::nifi::minifi;
-int main(int argc, char **argv) {
- const auto logger =
minifi::core::logging::LoggerConfiguration::getConfiguration().getLogger("controller");
+std::shared_ptr<minifi::core::controller::ControllerService>
getControllerService(const std::shared_ptr<minifi::Configure> &configuration,
+ const std::string &service_name, const std::string& minifi_home) {
+ std::string nifi_configuration_class_name = "yamlconfiguration";
Review Comment:
line 44 needs to be updated, too, to use `nifi_flow_configuration_file`
instead of `"$HOME/conf/config.yml"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
