tpalfy commented on code in PR #6987: URL: https://github.com/apache/nifi/pull/6987#discussion_r1152231435
########## nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/strategy/publisher/FlowFileReader.java: ########## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.jms.processors.strategy.publisher; + +import org.apache.nifi.flowfile.FlowFile; +import org.apache.nifi.processor.ProcessSession; + +public interface FlowFileReader { + void processFlowFileContent(ProcessSession session, FlowFile flowFile, MessageHandler messageHandler, MessagePublisherCallback messagePublisherCallback); Review Comment: Wholeheartedly disagree. While there are multiple responsibilities here indeed (this method reads the content of the flowfile, handles that content in some way and does administrative work) the new name would simply hide this with a misleading notation - reading is only the first step of a multistep processing. Here's my suggestion as part of a more consistent nomenclature: ```java public interface FlowFileContentProcessor { void processContent(ProcessSession session, FlowFile flowFile, FlowFileContentHandler flowFileContentHandler, FlowFileContentProcessorCallback flowFileContentProcessorCallback); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
