[ 
https://issues.apache.org/jira/browse/NIFI-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15688932#comment-15688932
 ] 

ASF subversion and git services commented on NIFI-3086:
-------------------------------------------------------

Commit 066accc274540bb2bfd392cffd1e86bb9ff48bb0 in nifi's branch 
refs/heads/master from [~jtstorck]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=066accc ]

NIFI-3086 Updated TailFile.java to deal with windows paths that were breaking 
the regex parsing Fixed documentation misspelling in TailFile.java Fixed 
assertions in several tests in TestTailFile that were dependent on the received 
order of flowfiles, this was differing between Windows and MacOS/Linux

This closes #1264

Signed-off-by: jpercivall <[email protected]>


> TestTailFile failures
> ---------------------
>
>                 Key: NIFI-3086
>                 URL: https://issues.apache.org/jira/browse/NIFI-3086
>             Project: Apache NiFi
>          Issue Type: Sub-task
>         Environment: Windows 8
>            Reporter: Joseph Percivall
>            Assignee: Jeff Storck
>            Priority: Blocker
>             Fix For: 1.1.0
>
>
> Changes to TailFile since 1.0.0:
> https://github.com/apache/nifi/commit/930e95aa0023b12e5618068ea144808e5627cea7
> https://github.com/apache/nifi/commit/cc2fbcaac457ebbfeaada4a0fba84db784bfc9a4
> Tests run: 18, Failures: 1, Errors: 3, Skipped: 0, Time elapsed: 10.394 sec 
> <<< FAILURE! - in org.apache.nifi.processors.standard.TestTailFile
> testMultipleFilesInSameDirectory(org.apache.nifi.processors.standard.TestTailFile)
>   Time elapsed: 0.014 sec  <<< ERROR!
> java.util.regex.PatternSyntaxException: Illegal/unsupported escape sequence 
> near index 7
> target\log(ging)?.txt
>        ^
>         at java.util.regex.Pattern.error(Pattern.java:1955)
>         at java.util.regex.Pattern.escape(Pattern.java:2471)
>         at java.util.regex.Pattern.atom(Pattern.java:2198)
>         at java.util.regex.Pattern.sequence(Pattern.java:2130)
>         at java.util.regex.Pattern.expr(Pattern.java:1996)
>         at java.util.regex.Pattern.compile(Pattern.java:1696)
>         at java.util.regex.Pattern.<init>(Pattern.java:1351)
>         at java.util.regex.Pattern.compile(Pattern.java:1028)
>         at 
> org.apache.nifi.processors.standard.TailFile.getFilesToTail(TailFile.java:419)
>         at 
> org.apache.nifi.processors.standard.TailFile.customValidate(TailFile.java:296)
>         at 
> org.apache.nifi.components.AbstractConfigurableComponent.validate(AbstractConfigurableComponent.java:126)
>         at 
> org.apache.nifi.util.MockProcessContext.validate(MockProcessContext.java:226)
>         at 
> org.apache.nifi.util.MockProcessContext.assertValid(MockProcessContext.java:243)
>         at 
> org.apache.nifi.util.StandardProcessorTestRunner.run(StandardProcessorTestRunner.java:161)
>         at 
> org.apache.nifi.util.StandardProcessorTestRunner.run(StandardProcessorTestRunner.java:152)
>         at 
> org.apache.nifi.util.StandardProcessorTestRunner.run(StandardProcessorTestRunner.java:147)
>         at 
> org.apache.nifi.util.StandardProcessorTestRunner.run(StandardProcessorTestRunner.java:142)
>         at 
> org.apache.nifi.processors.standard.TestTailFile.testMultipleFilesInSameDirectory(TestTailFile.java:656)
> testMultipleFilesWithBasedirAndFilenameEL(org.apache.nifi.processors.standard.TestTailFile)
>   Time elapsed: 0.157 sec  <<< ERROR!
> java.util.regex.PatternSyntaxException: Unmatched closing ')' near index 15
> target\(testDir/)?log(ging)?.txt
>                ^
>         at java.util.regex.Pattern.error(Pattern.java:1955)
>         at java.util.regex.Pattern.compile(Pattern.java:1700)
>         at java.util.regex.Pattern.<init>(Pattern.java:1351)
>         at java.util.regex.Pattern.compile(Pattern.java:1028)
>         at 
> org.apache.nifi.processors.standard.TailFile.getFilesToTail(TailFile.java:419)
>         at 
> org.apache.nifi.processors.standard.TailFile.customValidate(TailFile.java:296)
>         at 
> org.apache.nifi.components.AbstractConfigurableComponent.validate(AbstractConfigurableComponent.java:126)
>         at 
> org.apache.nifi.util.MockProcessContext.validate(MockProcessContext.java:226)
>         at 
> org.apache.nifi.util.MockProcessContext.assertValid(MockProcessContext.java:243)
>         at 
> org.apache.nifi.util.StandardProcessorTestRunner.run(StandardProcessorTestRunner.java:161)
>         at 
> org.apache.nifi.util.StandardProcessorTestRunner.run(StandardProcessorTestRunner.java:152)
>         at 
> org.apache.nifi.util.StandardProcessorTestRunner.run(StandardProcessorTestRunner.java:147)
>         at 
> org.apache.nifi.util.StandardProcessorTestRunner.run(StandardProcessorTestRunner.java:142)
>         at 
> org.apache.nifi.processors.standard.TestTailFile.testMultipleFilesWithBasedirAndFilenameEL(TestTailFile.java:634)
> testMultipleFilesChangingNameStrategy(org.apache.nifi.processors.standard.TestTailFile)
>   Time elapsed: 0.026 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<2> but was:<0>
>         at org.junit.Assert.fail(Assert.java:88)
>         at org.junit.Assert.failNotEquals(Assert.java:834)
>         at org.junit.Assert.assertEquals(Assert.java:645)
>         at org.junit.Assert.assertEquals(Assert.java:631)
>         at 
> org.apache.nifi.util.StandardProcessorTestRunner.assertTransferCount(StandardProcessorTestRunner.java:319)
>         at 
> org.apache.nifi.util.StandardProcessorTestRunner.assertAllFlowFilesTransferred(StandardProcessorTestRunner.java:314)
>         at 
> org.apache.nifi.processors.standard.TestTailFile.testMultipleFilesChangingNameStrategy(TestTailFile.java:738)
> testMultipleFiles(org.apache.nifi.processors.standard.TestTailFile)  Time 
> elapsed: 0.139 sec  <<< ERROR!
> java.util.regex.PatternSyntaxException: Unmatched closing ')' near index 15
> target\(testDir/)?log(ging)?.txt
>                ^
>         at java.util.regex.Pattern.error(Pattern.java:1955)
>         at java.util.regex.Pattern.compile(Pattern.java:1700)
>         at java.util.regex.Pattern.<init>(Pattern.java:1351)
>         at java.util.regex.Pattern.compile(Pattern.java:1028)
>         at 
> org.apache.nifi.processors.standard.TailFile.getFilesToTail(TailFile.java:419)
>         at 
> org.apache.nifi.processors.standard.TailFile.customValidate(TailFile.java:296)
>         at 
> org.apache.nifi.components.AbstractConfigurableComponent.validate(AbstractConfigurableComponent.java:126)
>         at 
> org.apache.nifi.util.MockProcessContext.validate(MockProcessContext.java:226)
>         at 
> org.apache.nifi.util.MockProcessContext.assertValid(MockProcessContext.java:243)
>         at 
> org.apache.nifi.util.StandardProcessorTestRunner.run(StandardProcessorTestRunner.java:161)
>         at 
> org.apache.nifi.util.StandardProcessorTestRunner.run(StandardProcessorTestRunner.java:152)
>         at 
> org.apache.nifi.util.StandardProcessorTestRunner.run(StandardProcessorTestRunner.java:147)
>         at 
> org.apache.nifi.util.StandardProcessorTestRunner.run(StandardProcessorTestRunner.java:142)
>         at 
> org.apache.nifi.processors.standard.TestTailFile.testMultipleFiles(TestTailFile.java:555)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to