martinzink commented on code in PR #1543:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1543#discussion_r1155846054
##########
extensions/http-curl/tests/HTTPHandlers.h:
##########
@@ -556,18 +556,18 @@ class HeartbeatHandler : public ServerAwareHandler {
std::vector<std::unordered_map<std::string, std::string>>
config_properties;
const auto prop_reader = [this](const std::string& sensitive_props) {
return configuration_->getString(sensitive_props); };
const auto sensitive_props =
minifi::Configuration::getSensitiveProperties(prop_reader);
- for (const auto& property :
minifi::Configuration::CONFIGURATION_PROPERTIES) {
- if (ranges::find(sensitive_props, property.name) !=
ranges::end(sensitive_props)) {
+ for (const auto& [property_name, property_validator] :
minifi::Configuration::CONFIGURATION_PROPERTIES) {
+ if (ranges::find(sensitive_props, property_name) !=
ranges::end(sensitive_props)) {
Review Comment:
Good idea, changed this and an other one couple lines down to use contains
https://github.com/apache/nifi-minifi-cpp/pull/1543/commits/64c5975e3fda0911820465778fa4d73f16d12002#diff-2c92592d65b3446aa7ec5a38236b3068aefb9163714268c77658c11d17dfe1baR560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
